CPD-13207: Add a retry of 60m for release download.#338
CPD-13207: Add a retry of 60m for release download.#338rutuja810 merged 1 commit intoproxy-cli-hook-aws-v3from
Conversation
rutuja810
force-pushed
the
CPD-13207
branch
2 times, most recently
from
8e4e011 to
09d6ed9
Compare
| Retriable.retriable on: RuntimeError do | ||
| retry_opts = { | ||
| tries: 360, # up to 360 x 10s = 60 minutes | ||
| max_elapsed_time: 60 * 60, # 60 minutes |
There was a problem hiding this comment.
60mins just to download a file form github? isnit it a bit excessive?
There was a problem hiding this comment.
it will retry for 1h, as pipeline sometime takes 32-33 min to finish.
There was a problem hiding this comment.
Isn't your pipeline that's taking longer? I think this should be configurable and you can define the retry properties in your pipeline, I'd not like mine have a such long retry if I don't need it 😉
There was a problem hiding this comment.
Hi Friend :)
We added retry on our pipeline here https://github.com/acquia/cloud-moonshot-plugins/pull/53/changes.
When release tag is cut it's using same sha as commit where pipeline has already passed so it is showing pipeline passed before triggering a new.
Change: minor Purpose: maintenance
4 participants
Change: minor
Purpose: maintenance
Motivation
Fixes #NNN
Proposed changes
Alternatives considered
Testing steps